Conversation
This fixes repository indexing (fixes #411), and makes config/repositories.yaml authoritative (again) on the operator configuration.
NickLarsenNZ
approved these changes
Jun 11, 2025
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
LGTM
Has the workflow been tested?
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Contributor
Author
|
I've tested the port numbering locally, and confirmed with a dry run that the sharding and, well, dry-run functionality still seems to work. Not sure why only airflow-operator is listed as having been modified in the CI logs... |
adwk67
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #411.
config/repositories.yaml is now authoritative (once again) for the details of repository configuration (but generate_prs.yml must still contain the names of all operators). Ansible now knows about the whole list of repositories and is responsible for filtering out the ones it cares about, rather than GitHub Actions generating a unique repository list for every shard. This means that Ansible is now able to generate proper indexes again.
Also refactors the github workflow a bit to avoid different code paths for dry and wet runs.